[PATCH 1/1] UBUNTU: SAUCE: remove python-xattr dependency

Paolo Pisati paolo.pisati at canonical.com
Thu Mar 5 14:28:20 UTC 2020


On Thu, Mar 5, 2020 at 11:06 AM Colin Ian King <colin.king at canonical.com> wrote:
>
> On 05/03/2020 10:46, Paolo Pisati wrote:
> > Starting with Python 3.3, handling of Linux extended attributes is now
> > part of the Python Standard Library (os module).
> >
> > On top of that, there isn't a single instantion of the xattr class, nor
> > any invokation of any xattr function in the entire autotest-client tree,
> > so i think this dependency is completely bogus and could be removed
> > altogether: i ran the patched ubuntu_xfstests_ext4 test in a Xenial VM
> > and in a Focal VM, and both completed fine.
>
> Does this work on older releases such as precise?

Nope, because the test is broken in Precise - i spawned a VM to try it:

1) ubuntu_xfstests_* tests have a dependency that doesn't exist in Precise:

...
14:06:30 WARNI| Could not find GDB installed. Crash handling will
operate with limited functionality
14:06:30 ERROR| [stderr] E: Unable to locate package thin-provisioning-tools
...

after removing the above dependency, setup() completed fine

2) the actual fs tests contained in the external repo 'xfstests-bld'
FTBFS in Precise:

...
  stdout:
  sed -e "s;@DIR@;$(pwd);" < kvm-xfstests/android-xfstests.in >
android-xfstests.sh
  sed -e "s;@DIR@;$(pwd);" < kvm-xfstests/gce-xfstests.in > gce-xfstests.sh
  sed -e "s;@DIR@;$(pwd);" < kvm-xfstests/kvm-xfstests.in > kvm-xfstests.sh
  chmod +x android-xfstests.sh
  chmod +x gce-xfstests.sh
  chmod +x kvm-xfstests.sh
  ./get-all
  ./build-all
  ----------------- 2020-03-05 14:13:27: Starting build of extended
attribute library
  checking build system type... x86_64-pc-linux-gnu
  checking host system type... x86_64-pc-linux-gnu
  checking how to print strings... printf
  checking for gcc... gcc
  checking whether the C compiler works... no
  stderr:
  configure: WARNING: unrecognized options: --disable-nls
  configure: error: in
`/home/ubuntu/k-testing/autotest/client/tmp/ubuntu_xfstests_ext4/src/xfstests-bld/attr':
  configure: error: C compiler cannot create executables
  See `config.log' for more details
  make: *** [all] Error 1
...



More information about the kernel-team mailing list