[PATCH 1/1] UBUNTU: SAUCE: remove python-xattr dependency

Colin Ian King colin.king at canonical.com
Thu Mar 5 10:04:40 UTC 2020


On 05/03/2020 10:46, Paolo Pisati wrote:
> Starting with Python 3.3, handling of Linux extended attributes is now
> part of the Python Standard Library (os module).
> 
> On top of that, there isn't a single instantion of the xattr class, nor
> any invokation of any xattr function in the entire autotest-client tree,
> so i think this dependency is completely bogus and could be removed
> altogether: i ran the patched ubuntu_xfstests_ext4 test in a Xenial VM
> and in a Focal VM, and both completed fine.

Does this work on older releases such as precise?

> 
> Signed-off-by: Paolo Pisati <paolo.pisati at canonical.com>
> ---
>  ubuntu_xfstests_btrfs/ubuntu_xfstests_btrfs.py | 1 -
>  ubuntu_xfstests_ext4/ubuntu_xfstests_ext4.py   | 1 -
>  ubuntu_xfstests_xfs/ubuntu_xfstests_xfs.py     | 1 -
>  xfstests/xfstests.py                           | 1 -
>  4 files changed, 4 deletions(-)
> 
> diff --git a/ubuntu_xfstests_btrfs/ubuntu_xfstests_btrfs.py b/ubuntu_xfstests_btrfs/ubuntu_xfstests_btrfs.py
> index d4fc5efa..2d3f99e2 100644
> --- a/ubuntu_xfstests_btrfs/ubuntu_xfstests_btrfs.py
> +++ b/ubuntu_xfstests_btrfs/ubuntu_xfstests_btrfs.py
> @@ -48,7 +48,6 @@ class ubuntu_xfstests_btrfs(test.test):
>              'libssl-dev',
>              'libtool',
>              'pkg-config',
> -            'python-xattr',
>              'quota',
>              'texinfo',
>              'texlive',
> diff --git a/ubuntu_xfstests_ext4/ubuntu_xfstests_ext4.py b/ubuntu_xfstests_ext4/ubuntu_xfstests_ext4.py
> index 3df4eae3..92b79b7d 100644
> --- a/ubuntu_xfstests_ext4/ubuntu_xfstests_ext4.py
> +++ b/ubuntu_xfstests_ext4/ubuntu_xfstests_ext4.py
> @@ -48,7 +48,6 @@ class ubuntu_xfstests_ext4(test.test):
>              'libssl-dev',
>              'libtool',
>              'pkg-config',
> -            'python-xattr',
>              'quota',
>              'texinfo',
>              'texlive',
> diff --git a/ubuntu_xfstests_xfs/ubuntu_xfstests_xfs.py b/ubuntu_xfstests_xfs/ubuntu_xfstests_xfs.py
> index 17578b82..c5ca83fb 100644
> --- a/ubuntu_xfstests_xfs/ubuntu_xfstests_xfs.py
> +++ b/ubuntu_xfstests_xfs/ubuntu_xfstests_xfs.py
> @@ -48,7 +48,6 @@ class ubuntu_xfstests_xfs(test.test):
>              'libssl-dev',
>              'libtool',
>              'pkg-config',
> -            'python-xattr',
>              'quota',
>              'texinfo',
>              'texlive',
> diff --git a/xfstests/xfstests.py b/xfstests/xfstests.py
> index 03dd3fe4..91845d5e 100644
> --- a/xfstests/xfstests.py
> +++ b/xfstests/xfstests.py
> @@ -35,7 +35,6 @@ class xfstests(test.test):
>              'autoconf',
>              'kpartx',
>              'libtool',
> -            'python-xattr',
>              'quota',
>              'bc',
>              'attr',
> 




More information about the kernel-team mailing list