NACK: [SRU][B / hwe][PATCH 2/2] UBUNTU: SAUCE: ptp: free ptp clock properly
andrea.righi at canonical.com
Thu Mar 5 07:43:59 UTC 2020
On Wed, Mar 04, 2020 at 06:29:52PM +0100, Andrea Righi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1864754
> There is a bug in ptp_clock_unregister() where ptp_clock_release() can
> free up resources needed by posix_clock_unregister() to properly destroy
> a related sysfs device.
> Fix this by calling posix_clock_unregister() in ptp_clock_release().
> This change is similar to 75718584cb3c64e6269109d4d54f888ac5a5fd15
> ("ptp: free ptp device pin descriptors properly").
> Fixes: 75718584cb3c64e6269109d4d54f888ac5a5fd15 ("ptp: fix the race between the release of ptp_clock and cdev").
> Signed-off-by: Andrea Righi <andrea.righi at canonical.com>
As pointed out in this thread:
This is not a valid fix, because it's preventing the oops by leaking
resources. I'll send a new patch when we'll figure out a valid fix.
NACK-ing this patch for now.
More information about the kernel-team