[SRU][B / hwe][PATCH 2/2] UBUNTU: SAUCE: ptp: free ptp clock properly
Andrea Righi
andrea.righi at canonical.com
Wed Mar 4 17:29:52 UTC 2020
BugLink: https://bugs.launchpad.net/bugs/1864754
There is a bug in ptp_clock_unregister() where ptp_clock_release() can
free up resources needed by posix_clock_unregister() to properly destroy
a related sysfs device.
Fix this by calling posix_clock_unregister() in ptp_clock_release().
This change is similar to 75718584cb3c64e6269109d4d54f888ac5a5fd15
("ptp: free ptp device pin descriptors properly").
Fixes: 75718584cb3c64e6269109d4d54f888ac5a5fd15 ("ptp: fix the race between the release of ptp_clock and cdev").
Signed-off-by: Andrea Righi <andrea.righi at canonical.com>
---
drivers/ptp/ptp_clock.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
index b84f16bbd6f24..3aeb8e4b0c4ba 100644
--- a/drivers/ptp/ptp_clock.c
+++ b/drivers/ptp/ptp_clock.c
@@ -171,6 +171,7 @@ static void ptp_clock_release(struct device *dev)
struct ptp_clock *ptp = container_of(dev, struct ptp_clock, dev);
ptp_cleanup_pin_groups(ptp);
+ posix_clock_unregister(&ptp->clock);
mutex_destroy(&ptp->tsevq_mux);
mutex_destroy(&ptp->pincfg_mux);
ida_simple_remove(&ptp_clocks_map, ptp->index);
@@ -303,8 +304,6 @@ int ptp_clock_unregister(struct ptp_clock *ptp)
if (ptp->pps_source)
pps_unregister_source(ptp->pps_source);
- posix_clock_unregister(&ptp->clock);
-
return 0;
}
EXPORT_SYMBOL(ptp_clock_unregister);
--
2.25.0
More information about the kernel-team
mailing list