ACK/Cmnt: [PATCH 0/8] [B][SRU] add 8 BD limit for tx flow

Stefan Bader stefan.bader at canonical.com
Thu Jul 9 08:32:22 UTC 2020


On 09.07.20 09:30, Ike Panhc wrote:
> BugLink: https://launchpad.net/bugs/1859756
> 
> We have reports hns3 is down while iscsi and spark tests.
> The first patch ("net: hns3: add 8 BD limit for tx flow")
> is the fix but also need to cherry-pick patch d1a37dedcfcf
> to fix a use-after-free issue introudcing by first fix.
> 
> To satisfy patch dependency and also several patches has
> to be cherry-picked along way.
> 
> These patches are also available in the Git repository at:
>   git://kernel.ubuntu.com/ikepanhc/public.git lp1859756.2
> 
> Peng Li (1):
>   net: hns3: add 8 BD limit for tx flow
> 
> Yunsheng Lin (7):
>   net: hns3: avoid mult + div op in critical data path
>   net: hns3: remove some ops in struct hns3_nic_ops
>   net: hns3: fix for not calculating tx bd num correctly
>   net: hns3: unify maybe_stop_tx for TSO and non-TSO case
>   net: hns3: add check for max TX BD num for tso and non-tso case
>   net: hns3: fix for TX queue not restarted problem
>   net: hns3: fix a use after free problem in hns3_nic_maybe_stop_tx()
> 
>  .../net/ethernet/hisilicon/hns3/hns3_enet.c   | 154 ++++++++----------
>  .../net/ethernet/hisilicon/hns3/hns3_enet.h   |  15 +-
>  .../ethernet/hisilicon/hns3/hns3_ethtool.c    |   1 +
>  3 files changed, 78 insertions(+), 92 deletions(-)
> 
Not sure whether all this really is needed to fix the bug. But on the other hand
this is for very specific hw and can be verified. Also I believe with this
driver we are already far away from original 4.15 code. So

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200709/65f36110/attachment.sig>


More information about the kernel-team mailing list