ACK/cmnt: [SRU B/D/E/F/U 0/1] Fix seccomp_bpf on powerpc

[Thadeu Lima de Souza Cascardo]

On Wed, Jul 01, 2020 at 09:54:42AM +0200, Juerg Haefliger wrote:
> On Tue, 30 Jun 2020 14:06:06 -0300
> Thadeu Lima de Souza Cascardo <cascardo at canonical.com> wrote:
> 
> > BugLink: https://bugs.launchpad.net/bugs/1885757
> > 
> > The patch has just been submitted upstream, still pending review.
> > 
> > [Impact]
> > seccomp_bpf test fails on powerpc and ends up being disabled on some series, or
> > causing engineers to waste their time verifying the same failures are the only
> > ones we see every kernel release.
> > 
> > [Test case]
> > Run the test and notice there are no more failures.
> > 
> > [Regression potential]
> > We may break the test on different architectures. That doesn't break users,
> > though, as the changes are only on tests. It has been tested at least on
> > ppc64el and amd64.
> > 
> > Thadeu Lima de Souza Cascardo (1):
> >   UBUNTU: SAUCE: selftests/seccomp: fix ptrace tests on powerpc
> > 
> >  tools/testing/selftests/seccomp/seccomp_bpf.c | 24 +++++++++++++++----
> >  1 file changed, 20 insertions(+), 4 deletions(-)
> 
> 
> This code makes my head spin but given the description it seems to make sense.
> Any particular reason why this wasn't tested on more architectures?
> 

No easy access to other architectures, and I wanted to get at least powerpc
done with. I will tackle other architectures in the future. s390 should be
next. Then, arm64.

Cascardo.

> It's 'only' selftests, so:
> 
> Acked-by: Juerg Haefliger <juergh at canonical.com>