[X][SRU][PATCH 1/1] selftests/net: skip psock_tpacket test if KALLSYMS was not enabled
Po-Hsu Lin
po-hsu.lin at canonical.com
Mon Apr 27 08:55:06 UTC 2020
BugLink: https://bugs.launchpad.net/bugs/1812176
The psock_tpacket test will need to access /proc/kallsyms, this would
require the kernel config CONFIG_KALLSYMS to be enabled first.
Apart from adding CONFIG_KALLSYMS to the net/config file here, check the
file existence to determine if we can run this test will be helpful to
avoid a false-positive test result when testing it directly with the
following commad against a kernel that have CONFIG_KALLSYMS disabled:
make -C tools/testing/selftests TARGETS=net run_tests
Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
Acked-by: Shuah Khan <skhan at linuxfoundation.org>
Signed-off-by: David S. Miller <davem at davemloft.net>
(backported from commit ff95bf28c23490584b9d75913a520bb7bb1f2ecb)
[PHLin: skip changes in config file]
Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
---
tools/testing/selftests/net/run_afpackettests | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/net/run_afpackettests b/tools/testing/selftests/net/run_afpackettests
index de1c625..39c773e 100755
--- a/tools/testing/selftests/net/run_afpackettests
+++ b/tools/testing/selftests/net/run_afpackettests
@@ -20,11 +20,15 @@ fi
echo "--------------------"
echo "running psock_tpacket test"
echo "--------------------"
-./in_netns.sh ./psock_tpacket
-if [ $? -ne 0 ]; then
- echo "[FAIL]"
- ret=1
+if [ -f /proc/kallsyms ]; then
+ ./in_netns.sh ./psock_tpacket
+ if [ $? -ne 0 ]; then
+ echo "[FAIL]"
+ ret=1
+ else
+ echo "[PASS]"
+ fi
else
- echo "[PASS]"
+ echo "[SKIP] CONFIG_KALLSYMS not enabled"
fi
exit $ret
--
2.7.4
More information about the kernel-team
mailing list