[X][B][D][SRU][PATCH 0/1] selftests/net: skip psock_tpacket test if KALLSYMS was not enabled

Po-Hsu Lin po-hsu.lin at canonical.com
Mon Apr 27 08:55:05 UTC 2020


== SRU Justification ==
The psock_tpacket test will need to access /proc/kallsyms, this would
require the kernel config CONFIG_KALLSYMS to be enabled first.

It causes the test to fail with the following error on our KVM kernels:
  test: TPACKET_V1 with PACKET_RX_RING open: No such file or directory

Apart from adding CONFIG_KALLSYMS to the net/config file here, check the
file existence to determine if we can run this test will be helpful to
avoid a false-positive test result when testing it directly with the
following commad against a kernel that have CONFIG_KALLSYMS disabled:
    make -C tools/testing/selftests TARGETS=net run_tests

== Fix ==
* ff95bf28c234 ("selftests/net: skip psock_tpacket test if KALLSYMS was
 not enabled")

This patch can be cherry-picked into Disco, but needs to be backported
for X/B as they don't have an up-to-date config list.

== Test ==
Tested on KVM kernels and this patch works as expected.

== Regression Potential ==
Low, changes limited to the testing tool.

Po-Hsu Lin (1):
  selftests/net: skip psock_tpacket test if KALLSYMS was not enabled

 tools/testing/selftests/net/config            |  1 +
 tools/testing/selftests/net/run_afpackettests | 14 +++++++++-----
 2 files changed, 10 insertions(+), 5 deletions(-)

-- 
2.7.4




More information about the kernel-team mailing list