NACK: [PATCH 0/3] Lenovo Yoga C630

[Lee Jones]

On Wed, 25 Sep 2019, Stefan Bader wrote:

> On 06.09.19 11:38, Lee Jones wrote:
> > Here are 3 patches which ensure successful booting of the AArch64 based
> > Lenovo Yoga C630 laptop, assuming [0] are enabled in your distro (a
> > patch to enable them in the upstream defconfig is in -next).
> > 
> > The other two patches are proper bug fixes.  The first ensures the
> > avoidance of a NULL dereference when booting with ACPI, the second
> > ensures that an I2C transation do not cause a platform reboot.
> > 
> > Although the DTS patch is not a strictly bug-fix is considered very
> > low risk, but high reward (for Linaro Yoga C630 owners).
> > 
> > NB: These patches have already been applied to Fedora earlier today.
> > 
> > [0]
> >  CONFIG_I2C_QCOM_GENI=m
> >  CONFIG_FB_EFI=y
> >  CONFIG_PHY_QCOM_QUSB2=m
> > 
> > Bjorn Andersson (1):
> >   arm64: dts: qcom: Add Lenovo Yoga C630
> > 
> > Lee Jones (2):
> >   soc: qcom: geni: Provide parameter error checking
> >   i2c: qcom-geni: Disable DMA processing on the Lenovo Yoga C630
> > 
> >  arch/arm64/boot/dts/qcom/Makefile             |   1 +
> >  .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 446 ++++++++++++++++++
> >  drivers/i2c/busses/i2c-qcom-geni.c            |  12 +-
> >  drivers/soc/qcom/qcom-geni-se.c               |   6 +
> >  4 files changed, 461 insertions(+), 4 deletions(-)
> >  create mode 100644 arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts

Good evening Stefan,

I hope all is well with you.

> Lee, you should know the drill.

I'm sure you can cut me a little slack - it's been a decade. :)

> Those patches miss provenance (where do thy come from? (ideally
> cherry picked from upstream)), any hint about the target series, and
> most importantly any hint why we should even think about

soc: qcom: geni: Provide parameter error checking
  - Already in v5.3

arm64: dts: qcom: Add Lenovo Yoga C630
  - Already in v5.4

i2c: qcom-geni: Disable DMA processing on the Lenovo Yoga C630
  - In I2C Next - should hit the merge-window any day now

> a bug report

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1845347

> And personally, hiding the destination mailing list is bad style.

This set was sent to; Debian, Fedora, Ubuntu and SUSE.

Kind regards,
Lee

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog