NACK: [PATCH 0/3] Lenovo Yoga C630

[Stefan Bader]

On 06.09.19 11:38, Lee Jones wrote:
> Here are 3 patches which ensure successful booting of the AArch64 based
> Lenovo Yoga C630 laptop, assuming [0] are enabled in your distro (a
> patch to enable them in the upstream defconfig is in -next).
> 
> The other two patches are proper bug fixes.  The first ensures the
> avoidance of a NULL dereference when booting with ACPI, the second
> ensures that an I2C transation do not cause a platform reboot.
> 
> Although the DTS patch is not a strictly bug-fix is considered very
> low risk, but high reward (for Linaro Yoga C630 owners).
> 
> NB: These patches have already been applied to Fedora earlier today.
> 
> [0]
>  CONFIG_I2C_QCOM_GENI=m
>  CONFIG_FB_EFI=y
>  CONFIG_PHY_QCOM_QUSB2=m
> 
> Bjorn Andersson (1):
>   arm64: dts: qcom: Add Lenovo Yoga C630
> 
> Lee Jones (2):
>   soc: qcom: geni: Provide parameter error checking
>   i2c: qcom-geni: Disable DMA processing on the Lenovo Yoga C630
> 
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 446 ++++++++++++++++++
>  drivers/i2c/busses/i2c-qcom-geni.c            |  12 +-
>  drivers/soc/qcom/qcom-geni-se.c               |   6 +
>  4 files changed, 461 insertions(+), 4 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> 
Lee, you should know the drill. Those patches miss provenance (where do thy come
from? (ideally cherry picked from upstream)), a bug report, any hint about the
target series, and most importantly any hint why we should even think about
considering. And personally, hiding the destination mailing list is bad style.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190925/e9ecb6c5/attachment.sig>