ACK: [PATCH][SRU][Disco] UBUNTU: SAUCE: shiftfs: mark slab objects SLAB_RECLAIM_ACCOUNT
Stefan Bader
stefan.bader at canonical.com
Wed Sep 25 08:20:30 UTC 2019
On 30.08.19 14:14, Christian Brauner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1842059
>
> Shiftfs does not mark it's slab cache as reclaimable. While this is not
> a big deal it is not nice to the kernel in general. The shiftfs cache is
> not so important that it can't be reclaimed.
>
> Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---
> fs/shiftfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/shiftfs.c b/fs/shiftfs.c
> index 400c3062365c..57e04a02d74c 100644
> --- a/fs/shiftfs.c
> +++ b/fs/shiftfs.c
> @@ -2102,7 +2102,7 @@ static int __init shiftfs_init(void)
> {
> shiftfs_file_info_cache = kmem_cache_create(
> "shiftfs_file_info_cache", sizeof(struct shiftfs_file_info), 0,
> - SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL);
> + SLAB_RECLAIM_ACCOUNT | SLAB_HWCACHE_ALIGN | SLAB_ACCOUNT | SLAB_MEM_SPREAD, NULL);
> if (!shiftfs_file_info_cache)
> return -ENOMEM;
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190925/f154d493/attachment.sig>
More information about the kernel-team
mailing list