[SRU][Bionic][PATCH 1/1] Revert "uio: use request_threaded_irq instead"

Kamal Mostafa kamal at canonical.com
Thu Oct 31 16:23:00 UTC 2019


From: Xiubo Li <xiubli at redhat.com>

BugLink: https://bugs.launchpad.net/bugs/1843487

Since mutex lock in irq hanler is useless currently, here will
remove it together with it.

This reverts commit 9421e45f5ff3d558cf8b75a8cc0824530caf3453.

Reported-by: james.r.harris at intel.com
CC: Ahsan Atta <ahsan.atta at intel.com>
Signed-off-by: Xiubo Li <xiubli at redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
(backported from commit 3d27c4de8d4fb2d4099ff324671792aa2578c6f9)
[kamal: applied just the mutex removal bit.]
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
 drivers/uio/uio.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index c7bc6b8f8d22..fb5c9701b1fb 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -445,13 +445,10 @@ static irqreturn_t uio_interrupt(int irq, void *dev_id)
 	struct uio_device *idev = (struct uio_device *)dev_id;
 	irqreturn_t ret;
 
-	mutex_lock(&idev->info_lock);
-
 	ret = idev->info->handler(irq, idev->info);
 	if (ret == IRQ_HANDLED)
 		uio_event_notify(idev->info);
 
-	mutex_unlock(&idev->info_lock);
 	return ret;
 }
 
-- 
2.17.1




More information about the kernel-team mailing list