REVERTED: [Bionic][Cosmic][Disco] UBUNTU: SAUCE: [ALSA] Headset fixup for System76 Gazelle (gaze14)

[Connor Kuehl]

On 5/15/19 5:54 AM, Jeremy Soller wrote:
> Thanks Stefan. Assuming the previous patches were not applied, here is the complete and correct patch that has now been applied upstream:
> 
> BugLink: https://bugs.launchpad.net/bugs/1827555
> 
> On the System76 Gazelle (gaze14) variants with a GTX 1660Ti, there is a headset
> microphone input attached to 0x1a that does not have a jack detect. In order to
> get it working, the pin configuration needs to be set correctly, and the
> ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is
> identical to the ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE fixup already applied
> for the System76 Darter Pro (darp5).
> 
> On the System76 Gazelle (gaze14) variants with a GTX 1650, there is a headset
> microphone input that is not parsed correctly. In order to get it working, the  
> ALC269_FIXUP_HEADSET_MIC fixup needs to be applied.
> 
> Tests were done on all four variants ensuring full audio capability:
> - 15 inch with GTX 1660 Ti (0x8550)
> - 17 inch with GTX 1660 Ti (0x8551)
> - 15 inch with GTX 1650 (0x8560)
> - 17 inch with GTX 1650 (0x8561)
> 
> Signed-off-by: Jeremy Soller <jeremy at system76.com>
> 
> ---

Hi Jeremy,

If this patch has been submitted, accepted, and applied upstream then
it's important that we carry the provenance from upstream along with it
as well as the upstream commit SHA. There's an example on this page:
https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat specifically under
the "Comment Body" section with list items #3 and #4.

Also, just a gentle reminder that since it's been accepted upstream, the
e-mail/git subject should no longer contain "UBUNTU: SAUCE" :-)

Thanks,

Connor

> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 00c27b3b8c14..3e790b49c1c0 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6900,6 +6900,10 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>         SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
>         SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
>         SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> +       SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> +       SND_PCI_QUIRK(0x1558, 0x8551, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> +       SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
> +       SND_PCI_QUIRK(0x1558, 0x8561, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
>         SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
>         SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
>         SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
> 


-- 
Connor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pEpkey.asc
Type: application/pgp-keys
Size: 5950 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190528/da6c32e3/attachment.key>