ACK: [X][B][C][D][Unstable][PATCH 0/1] selftests/net: correct the return value for run_netsocktests

Khaled Elmously khalid.elmously at canonical.com
Tue May 7 02:34:37 UTC 2019


On 2019-05-03 11:08:08 , Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1825777
> 
> == SRU Justification ==
> 
> The run_netsocktests from net in ubuntu_kernel_selftest will be marked
> as passed regardless the actual test result from the ./socket:
> 
>     selftests: net: run_netsocktests
>     ========================================
>     --------------------
>     running socket test
>     --------------------
>     [FAIL]
>     ok 1..6 selftests: net: run_netsocktests [PASS]
> 
> This is because the test script itself has been successfully executed,
> and make it return 0.
> 
> == Fix ==
> 30c04d79 (selftests/net: correct the return value for run_netsocktests)
> 
> This can be cherry-picked into all of our kernels.
> 
> == Test ==
> Patch tested and submitted to the upstream.
> 
> == Regression Potential ==
> Changes limit to the testing tool, and it's is expected to see failures
> from this test in the future.
> 
> Po-Hsu Lin (1):
>   selftests/net: correct the return value for run_netsocktests
> 
>  tools/testing/selftests/net/run_netsocktests | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Khalid Elmously <khalid.elmously at canonical.com>




More information about the kernel-team mailing list