ACK: [X][B][C][D][Unstable][PATCH 1/1] selftests/net: correct the return value for run_netsocktests

[Kleber Souza]

On 5/3/19 5:08 AM, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1825777
> 
> The run_netsocktests will be marked as passed regardless the actual test
> result from the ./socket:
> 
>     selftests: net: run_netsocktests
>     ========================================
>     --------------------
>     running socket test
>     --------------------
>     [FAIL]
>     ok 1..6 selftests: net: run_netsocktests [PASS]
> 
> This is because the test script itself has been successfully executed.
> Fix this by exit 1 when the test failed.
> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
> Signed-off-by: David S. Miller <davem at davemloft.net>
> (cherry picked from commit 30c04d796b693e22405c38e9b78e9a364e4c77e6)
> Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>

> ---
>  tools/testing/selftests/net/run_netsocktests | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/run_netsocktests b/tools/testing/selftests/net/run_netsocktests
> index b093f39c2..14e41fa 100755
> --- a/tools/testing/selftests/net/run_netsocktests
> +++ b/tools/testing/selftests/net/run_netsocktests
> @@ -7,7 +7,7 @@ echo "--------------------"
>  ./socket
>  if [ $? -ne 0 ]; then
>  	echo "[FAIL]"
> +	exit 1
>  else
>  	echo "[PASS]"
>  fi
> -
>