ACK: [C][SRU][PATCH 0/3] Fix the audio on some Chromebooks

Kleber Souza kleber.souza at canonical.com
Thu Jan 31 16:16:01 UTC 2019


On 1/15/19 4:13 AM, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1811566
>
> == Justification ==
> Commit 648e921888ad96ea3dc922739e96716ad3225d7f (clk: x86: Stop marking clocks
> as CLK_IS_CRITICAL) backported to Cosmic kernel fixed the bug that keeps unused
> clocks on, but it is breaking the audio support on some Chromebooks (Swanky /
> Clapper/ Gnawty) since we were not using the right clock in the
> cht_bsw_max98090_ti machine driver.
>
> == Fix ==
> a182ecd (ASoC: intel: cht_bsw_max98090_ti: Add quirk for boards using pmc_plt_clk_0)
> 984bfb3 (ASoC: intel: cht_bsw_max98090_ti: Add pmc_plt_clk_0 quirk)
> 94ea56c (ASoC: intel: cht_bsw_max98090_ti: Add pmc_plt_clk_0 quirk)
>
> These 3 patches can be cherry-picked to Cosmic.
>
> == Test ==
> Test kernel with these 3 patches could be found in:
> http://people.canonical.com/~phlin/kernel/lp-1811566-chromebook-Gnawty/
>
> Bug reporter stated that this kernel can fix the audio issue as expected.
>
> == Regression potential ==
> Low,
> changes are limited in the cht_bsw_max98090_ti driver with a new DMI based
> quirk table that contains these 3 Chromebook models and some logic to
> determine the right clock to use.
>
>
> Hans de Goede (3):
>   ASoC: intel: cht_bsw_max98090_ti: Add quirk for boards using
>     pmc_plt_clk_0
>   ASoC: intel: cht_bsw_max98090_ti: Add pmc_plt_clk_0 quirk for
>     Chromebook Clapper
>   ASoC: intel: cht_bsw_max98090_ti: Add pmc_plt_clk_0 quirk for
>     Chromebook Gnawty
>
>  sound/soc/intel/boards/cht_bsw_max98090_ti.c | 46 ++++++++++++++++++++++++++--
>  1 file changed, 43 insertions(+), 3 deletions(-)
>
Clean cherry-picks, limited to specific hard and with good test results.

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>




More information about the kernel-team mailing list