ACK: [C][SRU][PATCH 0/3] Fix the audio on some Chromebooks

[Po-Hsu Lin]

Hi Stefan,

For the Disco nomination, I have mark it as Fix-released and remove
the disco tag as it has already include this patchset.
It looks like this patchset is in the unstable tree as well.
Hope this is correct.

Thanks
Sam

On Tue, Jan 15, 2019 at 9:59 PM Stefan Bader <stefan.bader at canonical.com> wrote:
>
> On 15.01.19 04:13, Po-Hsu Lin wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1811566
> >
> > == Justification ==
> > Commit 648e921888ad96ea3dc922739e96716ad3225d7f (clk: x86: Stop marking clocks
> > as CLK_IS_CRITICAL) backported to Cosmic kernel fixed the bug that keeps unused
> > clocks on, but it is breaking the audio support on some Chromebooks (Swanky /
> > Clapper/ Gnawty) since we were not using the right clock in the
> > cht_bsw_max98090_ti machine driver.
> >
> > == Fix ==
> > a182ecd (ASoC: intel: cht_bsw_max98090_ti: Add quirk for boards using pmc_plt_clk_0)
> > 984bfb3 (ASoC: intel: cht_bsw_max98090_ti: Add pmc_plt_clk_0 quirk)
> > 94ea56c (ASoC: intel: cht_bsw_max98090_ti: Add pmc_plt_clk_0 quirk)
> >
> > These 3 patches can be cherry-picked to Cosmic.
> >
> > == Test ==
> > Test kernel with these 3 patches could be found in:
> > http://people.canonical.com/~phlin/kernel/lp-1811566-chromebook-Gnawty/
> >
> > Bug reporter stated that this kernel can fix the audio issue as expected.
> >
> > == Regression potential ==
> > Low,
> > changes are limited in the cht_bsw_max98090_ti driver with a new DMI based
> > quirk table that contains these 3 Chromebook models and some logic to
> > determine the right clock to use.
> >
> >
> > Hans de Goede (3):
> >   ASoC: intel: cht_bsw_max98090_ti: Add quirk for boards using
> >     pmc_plt_clk_0
> >   ASoC: intel: cht_bsw_max98090_ti: Add pmc_plt_clk_0 quirk for
> >     Chromebook Clapper
> >   ASoC: intel: cht_bsw_max98090_ti: Add pmc_plt_clk_0 quirk for
> >     Chromebook Gnawty
> >
> >  sound/soc/intel/boards/cht_bsw_max98090_ti.c | 46 ++++++++++++++++++++++++++--
> >  1 file changed, 43 insertions(+), 3 deletions(-)
> >
> Limited risk for further regressions and testable. Just wondering about the
> Disco nomination in the bug report. Is that still needed or just waiting on
> moving ahead to unstable soon.
>
> Acked-by: Stefan Bader <stefan.bader at canonical.com>
>