ACK: [SRU][Artful][Bionic][PATCH 0/1] staging: sm750fb: Fix parameter mistake in poke32

Colin Ian King colin.king at canonical.com
Tue Jan 23 17:57:46 UTC 2018


On 19/01/18 15:17, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1742721
> 
> == SRU Justification ==
> The following mainline commit introduced a regression in v4.11-rc1:
> c075b6f2d357ea9 ("staging: sm750fb: Replace POKE32 and PEEK32 by inline functions")
> 
> This regression caused the bug reporters system to crash and exhibited no display 
> output. This bug affects several end users. 
> 
> A "Reverse" bisect was performed and it was found that this regression is 
> fixed by commit 16808dcf605e6, which was added to mainline in v4.15-rc1.
>     
> 
> == Fix ==
> commit 16808dcf605e6302319a8c3266789b76d4c0983b
> Author: Huacai Chen <chenhc at lemote.com>
> Date:   Mon Nov 6 08:43:03 2017 +0800
> 
>     staging: sm750fb: Fix parameter mistake in poke32
> 
> == Regression Potential ==
> Low.  This patch fixes a current regression.  It was cc'd to upstream stable
> so had additional upstream review.
> 
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Huacai Chen (1):
>   staging: sm750fb: Fix parameter mistake in poke32
> 
>  drivers/staging/sm750fb/ddk750_chip.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Positive test results, clearly fixes the swapped args to the function.
Clean upstream commit, and already in Bionic.

Acked-by: Colin Ian King <colin.king at canonical.com>




More information about the kernel-team mailing list