[SRU][Artful][Bionic][PATCH 1/1] staging: sm750fb: Fix parameter mistake in poke32

Joseph Salisbury joseph.salisbury at canonical.com
Fri Jan 19 15:17:16 UTC 2018


From: Huacai Chen <chenhc at lemote.com>

BugLink: http://bugs.launchpad.net/bugs/1742721

In commit c075b6f2d357ea9 ("staging: sm750fb: Replace POKE32 and PEEK32
by inline functions"), POKE32 has been replaced by the inline function
poke32. But it exchange the "addr" and "data" parameters by mistake, so
fix it.

Fixes: c075b6f2d357ea9 ("staging: sm750fb: Replace POKE32 and PEEK32 by inline functions"),
Signed-off-by: Huacai Chen <chenhc at lemote.com>
Signed-off-by: Liangliang Huang <huangll at lemote.com>
Cc: stable <stable at vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
(cherry picked from commit 16808dcf605e6302319a8c3266789b76d4c0983b)
Signed-off-by: Joseph Salisbury <joseph.salisbury at canonical.com>
---
 drivers/staging/sm750fb/ddk750_chip.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h
index 2c7a9b9..d9d4c48 100644
--- a/drivers/staging/sm750fb/ddk750_chip.h
+++ b/drivers/staging/sm750fb/ddk750_chip.h
@@ -17,7 +17,7 @@ static inline u32 peek32(u32 addr)
 	return readl(addr + mmio750);
 }
 
-static inline void poke32(u32 data, u32 addr)
+static inline void poke32(u32 addr, u32 data)
 {
 	writel(data, addr + mmio750);
 }
-- 
2.7.4





More information about the kernel-team mailing list