[PATCH][SRU][Bionic] scsi: libiscsi: Allow sd_shutdown on bad transport

[Kleber Souza]

On 01/23/18 17:05, Rafael David Tinoco wrote:
> 
>> On 23/01/2018, at 02:00 PM, Kleber Souza <kleber.souza at canonical.com> wrote:
>>
>>>> In this case it could be:
>>>>
>>>> [PATCH][SRU][Bionic][Artful][Xenial][Trusty] scsi: libiscsi: ...
>>>
>>> Good to know. Will use in the future. For this case, please note that
>>> the Trusty patch wasn't clean cherry-pick, like others, but didn't
>>> differ in anything meaningful.
>>
>> When it doesn't apply cleanly please mark it as (backported from ...),
>> even if it's only for small things such as context adjustment. The rule
>> is that 'cherry picked from ...' should be used only if the patch can be
>> applied with git am.
>>
>> Also, to help making the review a bit easier for us, the patches can be
>> sent in a thread with a cover letter containing the SRU justification.
> 
> Makes perfect sense. Should I re-do it ? What do you prefer ?
> 
> Tku
> 

Could you please re-send the patches?

Another note [sorry for so many small rules :-)]: we try to keep the
original provenance block of the original patch intact and add the
additional information below it. So in this case that you are also the
original author of the patch, that would require another SOB line and
the backport/cherry-pick information, so it would be something like this:

Signed-off-by: Rafael David Tinoco <rafael.tinoco at canonical.com>
Reviewed-by: [...]
Signed-off-by: [...]
(cherry-picked from commit d754941225a7dbc61f6dd2173fa9498049f9a7ee
next-20180117)
Signed-off-by: Rafael David Tinoco <rafael.tinoco at canonical.com>


thanks!
Kleber