ACK/cmnt: [Bionic][PATCH] UBUNTU: SAUCE: fix warning from "ipvlan: drop ipv6 dependency"
Khaled Elmously
khalid.elmously at canonical.com
Mon Aug 13 15:10:32 UTC 2018
On 2018-08-07 16:24:29 , Kamal Mostafa wrote:
> Backport commit eacec4b "ipvlan: drop ipv6 dependency" inadvertently
> introduced an unused function ipvlan_is_valid_dev(), which should be
> dropped.
>
> Ignore: yes
>
> Signed-off-by: Kamal Mostafa <kamal at canonical.com>
> ---
> drivers/net/ipvlan/ipvlan_main.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
> index 0cfbcdf..b858e98 100644
> --- a/drivers/net/ipvlan/ipvlan_main.c
> +++ b/drivers/net/ipvlan/ipvlan_main.c
> @@ -847,19 +847,6 @@ static void ipvlan_del_addr(struct ipvl_dev *ipvlan, void *iaddr, bool is_v6)
> kfree_rcu(addr, rcu);
> }
>
> -static bool ipvlan_is_valid_dev(const struct net_device *dev)
> -{
> - struct ipvl_dev *ipvlan = netdev_priv(dev);
> -
> - if (!netif_is_ipvlan(dev))
> - return false;
> -
> - if (!ipvlan || !ipvlan->port)
> - return false;
> -
> - return true;
> -}
> -
> #if IS_ENABLED(CONFIG_IPV6)
> static int ipvlan_add_addr6(struct ipvl_dev *ipvlan, struct in6_addr *ip6_addr)
> {
> --
Not sure what to do for the next 49 minutes....
Acked-by: Khalid Elmously <khalid.elmously at canonical.com>
More information about the kernel-team
mailing list