[Bionic][PATCH] UBUNTU: SAUCE: fix warning from "ipvlan: drop ipv6 dependency"

Kleber Souza kleber.souza at canonical.com
Tue Aug 14 12:52:17 UTC 2018


On 08/08/18 01:24, Kamal Mostafa wrote:
> Backport commit eacec4b "ipvlan: drop ipv6 dependency" inadvertently
> introduced an unused function ipvlan_is_valid_dev(), which should be
> dropped.
> 
> Ignore: yes

Hi Kamal,

Any reason why we don't want this fix on the changelog?


thanks,
Kleber

> 
> Signed-off-by: Kamal Mostafa <kamal at canonical.com>
> ---
>  drivers/net/ipvlan/ipvlan_main.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
> index 0cfbcdf..b858e98 100644
> --- a/drivers/net/ipvlan/ipvlan_main.c
> +++ b/drivers/net/ipvlan/ipvlan_main.c
> @@ -847,19 +847,6 @@ static void ipvlan_del_addr(struct ipvl_dev *ipvlan, void *iaddr, bool is_v6)
>  	kfree_rcu(addr, rcu);
>  }
>  
> -static bool ipvlan_is_valid_dev(const struct net_device *dev)
> -{
> -	struct ipvl_dev *ipvlan = netdev_priv(dev);
> -
> -	if (!netif_is_ipvlan(dev))
> -		return false;
> -
> -	if (!ipvlan || !ipvlan->port)
> -		return false;
> -
> -	return true;
> -}
> -
>  #if IS_ENABLED(CONFIG_IPV6)
>  static int ipvlan_add_addr6(struct ipvl_dev *ipvlan, struct in6_addr *ip6_addr)
>  {
> 





More information about the kernel-team mailing list