ACK: [PATCH 0/4][SRU][Bionic] Add support RTS5260 card reader [10EC:5260]

[Thadeu Lima de Souza Cascardo]

On Mon, Apr 09, 2018 at 07:56:04PM +0800, AceLan Kao wrote:
> BugLink: http://bugs.launchpad.net/bugs/1737673
> 
> [Impact]
> Need new driver to support Realtek 5260 card reader[10ec:5260]
> 
> [Fix]
> It requires 3 commits to enable the cardreader, and another one for config updates.
>    51bd712 misc: rtsx: Fix symbol clashes
>    5da4e04 misc: rtsx: Add support for RTS5260
>    e455b69 misc: rtsx: Move Realtek Card Reader Driver to misc
> 
> [Test case]
> Verified on the new Readltek 5260 card reader[10ec:5260], and it can read MS card without issues.
> 
> [Regression Potential]
> Although it changes lots of files and changes the directories structure,
> the regression potential should be low, and only affects Realtek card reader only.

Though the diffstat mentions a huge number of changes, after applying the first
patch, one can confirm it's just moving things around. The second patch does
the expected fixup for the new config options. Hence, my ACK for the whole series.

Acked-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>

> 
> AceLan Kao (1):
>   UBUNTU: updateconfigs for Realtek Card Reader Driver
> 
> Rui Feng (2):
>   misc: rtsx: Move Realtek Card Reader Driver to misc
>   misc: rtsx: Add support for RTS5260
> 
> Stephen Rothwell (1):
>   misc: rtsx: Fix symbol clashes
> 
>  debian.master/config/amd64/config.common.amd64     |    3 +-
>  debian.master/config/arm64/config.common.arm64     |    3 +-
>  debian.master/config/armhf/config.common.armhf     |    3 +-
>  debian.master/config/config.common.ubuntu          |    2 +-
>  debian.master/config/i386/config.common.i386       |    3 +-
>  debian.master/config/ppc64el/config.common.ppc64el |    3 +-
>  debian.master/config/s390x/config.common.s390x     |    3 +-
>  drivers/memstick/host/Kconfig                      |    4 +-
>  drivers/memstick/host/rtsx_pci_ms.c                |    2 +-
>  drivers/memstick/host/rtsx_usb_ms.c                |    2 +-
>  drivers/mfd/Kconfig                                |   21 -
>  drivers/mfd/Makefile                               |    4 -
>  drivers/mfd/rtl8411.c                              |  508 ------
>  drivers/mfd/rts5209.c                              |  277 ----
>  drivers/mfd/rts5227.c                              |  374 -----
>  drivers/mfd/rts5229.c                              |  273 ----
>  drivers/mfd/rts5249.c                              |  741 ---------
>  drivers/mfd/rtsx_pcr.c                             | 1572 ------------------
>  drivers/mfd/rtsx_pcr.h                             |  103 --
>  drivers/mfd/rtsx_usb.c                             |  791 ---------
>  drivers/misc/Kconfig                               |    5 +
>  drivers/misc/Makefile                              |    1 +
>  drivers/misc/cardreader/Kconfig                    |   20 +
>  drivers/misc/cardreader/Makefile                   |    4 +
>  drivers/misc/cardreader/rtl8411.c                  |  508 ++++++
>  drivers/misc/cardreader/rts5209.c                  |  277 ++++
>  drivers/misc/cardreader/rts5227.c                  |  374 +++++
>  drivers/misc/cardreader/rts5229.c                  |  273 ++++
>  drivers/misc/cardreader/rts5249.c                  |  740 +++++++++
>  drivers/misc/cardreader/rts5260.c                  |  748 +++++++++
>  drivers/misc/cardreader/rts5260.h                  |   45 +
>  drivers/misc/cardreader/rtsx_pcr.c                 | 1693 ++++++++++++++++++++
>  drivers/misc/cardreader/rtsx_pcr.h                 |  113 ++
>  drivers/misc/cardreader/rtsx_usb.c                 |  791 +++++++++
>  drivers/mmc/host/Kconfig                           |    4 +-
>  drivers/mmc/host/rtsx_pci_sdmmc.c                  |    2 +-
>  drivers/mmc/host/rtsx_usb_sdmmc.c                  |    2 +-
>  include/linux/mfd/rtsx_common.h                    |   50 -
>  include/linux/mfd/rtsx_pci.h                       | 1141 -------------
>  include/linux/mfd/rtsx_usb.h                       |  628 --------
>  include/linux/rtsx_common.h                        |   50 +
>  include/linux/rtsx_pci.h                           | 1367 ++++++++++++++++
>  include/linux/rtsx_usb.h                           |  628 ++++++++
>  43 files changed, 7658 insertions(+), 6498 deletions(-)
>  delete mode 100644 drivers/mfd/rtl8411.c
>  delete mode 100644 drivers/mfd/rts5209.c
>  delete mode 100644 drivers/mfd/rts5227.c
>  delete mode 100644 drivers/mfd/rts5229.c
>  delete mode 100644 drivers/mfd/rts5249.c
>  delete mode 100644 drivers/mfd/rtsx_pcr.c
>  delete mode 100644 drivers/mfd/rtsx_pcr.h
>  delete mode 100644 drivers/mfd/rtsx_usb.c
>  create mode 100644 drivers/misc/cardreader/Kconfig
>  create mode 100644 drivers/misc/cardreader/Makefile
>  create mode 100644 drivers/misc/cardreader/rtl8411.c
>  create mode 100644 drivers/misc/cardreader/rts5209.c
>  create mode 100644 drivers/misc/cardreader/rts5227.c
>  create mode 100644 drivers/misc/cardreader/rts5229.c
>  create mode 100644 drivers/misc/cardreader/rts5249.c
>  create mode 100644 drivers/misc/cardreader/rts5260.c
>  create mode 100644 drivers/misc/cardreader/rts5260.h
>  create mode 100644 drivers/misc/cardreader/rtsx_pcr.c
>  create mode 100644 drivers/misc/cardreader/rtsx_pcr.h
>  create mode 100644 drivers/misc/cardreader/rtsx_usb.c
>  delete mode 100644 include/linux/mfd/rtsx_common.h
>  delete mode 100644 include/linux/mfd/rtsx_pci.h
>  delete mode 100644 include/linux/mfd/rtsx_usb.h
>  create mode 100644 include/linux/rtsx_common.h
>  create mode 100644 include/linux/rtsx_pci.h
>  create mode 100644 include/linux/rtsx_usb.h
> 
> -- 
> 2.7.4