[PATCH 0/4][SRU][Bionic] Add support RTS5260 card reader [10EC:5260]

AceLan Kao acelan.kao at canonical.com
Thu Apr 12 01:21:08 UTC 2018


No, we don't have other realtek cardreaders here.
Checking the code in "drivers/misc/cardreader".
there is no more bug fix commit after those patches, so we may assume
that no bug report after the changes.


2018-04-10 22:34 GMT+08:00 Seth Forshee <seth.forshee at canonical.com>:
> On Mon, Apr 09, 2018 at 07:56:04PM +0800, AceLan Kao wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1737673
>>
>> [Impact]
>> Need new driver to support Realtek 5260 card reader[10ec:5260]
>>
>> [Fix]
>> It requires 3 commits to enable the cardreader, and another one for config updates.
>>    51bd712 misc: rtsx: Fix symbol clashes
>>    5da4e04 misc: rtsx: Add support for RTS5260
>>    e455b69 misc: rtsx: Move Realtek Card Reader Driver to misc
>>
>> [Test case]
>> Verified on the new Readltek 5260 card reader[10ec:5260], and it can read MS card without issues.
>>
>> [Regression Potential]
>> Although it changes lots of files and changes the directories structure,
>> the regression potential should be low, and only affects Realtek card reader only.
>>
>> AceLan Kao (1):
>>   UBUNTU: updateconfigs for Realtek Card Reader Driver
>>
>> Rui Feng (2):
>>   misc: rtsx: Move Realtek Card Reader Driver to misc
>>   misc: rtsx: Add support for RTS5260
>>
>> Stephen Rothwell (1):
>>   misc: rtsx: Fix symbol clashes
>>
>>  debian.master/config/amd64/config.common.amd64     |    3 +-
>>  debian.master/config/arm64/config.common.arm64     |    3 +-
>>  debian.master/config/armhf/config.common.armhf     |    3 +-
>>  debian.master/config/config.common.ubuntu          |    2 +-
>>  debian.master/config/i386/config.common.i386       |    3 +-
>>  debian.master/config/ppc64el/config.common.ppc64el |    3 +-
>>  debian.master/config/s390x/config.common.s390x     |    3 +-
>>  drivers/memstick/host/Kconfig                      |    4 +-
>>  drivers/memstick/host/rtsx_pci_ms.c                |    2 +-
>>  drivers/memstick/host/rtsx_usb_ms.c                |    2 +-
>>  drivers/mfd/Kconfig                                |   21 -
>>  drivers/mfd/Makefile                               |    4 -
>>  drivers/mfd/rtl8411.c                              |  508 ------
>>  drivers/mfd/rts5209.c                              |  277 ----
>>  drivers/mfd/rts5227.c                              |  374 -----
>>  drivers/mfd/rts5229.c                              |  273 ----
>>  drivers/mfd/rts5249.c                              |  741 ---------
>>  drivers/mfd/rtsx_pcr.c                             | 1572 ------------------
>>  drivers/mfd/rtsx_pcr.h                             |  103 --
>>  drivers/mfd/rtsx_usb.c                             |  791 ---------
>>  drivers/misc/Kconfig                               |    5 +
>>  drivers/misc/Makefile                              |    1 +
>>  drivers/misc/cardreader/Kconfig                    |   20 +
>>  drivers/misc/cardreader/Makefile                   |    4 +
>>  drivers/misc/cardreader/rtl8411.c                  |  508 ++++++
>>  drivers/misc/cardreader/rts5209.c                  |  277 ++++
>>  drivers/misc/cardreader/rts5227.c                  |  374 +++++
>>  drivers/misc/cardreader/rts5229.c                  |  273 ++++
>>  drivers/misc/cardreader/rts5249.c                  |  740 +++++++++
>>  drivers/misc/cardreader/rts5260.c                  |  748 +++++++++
>>  drivers/misc/cardreader/rts5260.h                  |   45 +
>>  drivers/misc/cardreader/rtsx_pcr.c                 | 1693 ++++++++++++++++++++
>>  drivers/misc/cardreader/rtsx_pcr.h                 |  113 ++
>>  drivers/misc/cardreader/rtsx_usb.c                 |  791 +++++++++
>>  drivers/mmc/host/Kconfig                           |    4 +-
>>  drivers/mmc/host/rtsx_pci_sdmmc.c                  |    2 +-
>>  drivers/mmc/host/rtsx_usb_sdmmc.c                  |    2 +-
>>  include/linux/mfd/rtsx_common.h                    |   50 -
>>  include/linux/mfd/rtsx_pci.h                       | 1141 -------------
>>  include/linux/mfd/rtsx_usb.h                       |  628 --------
>>  include/linux/rtsx_common.h                        |   50 +
>>  include/linux/rtsx_pci.h                           | 1367 ++++++++++++++++
>>  include/linux/rtsx_usb.h                           |  628 ++++++++
>>  43 files changed, 7658 insertions(+), 6498 deletions(-)
>
> Yikes, that's a lot of changes. Have you done regression testing with
> any of the other card readers affected by this shuffling?
>
> Thanks,
> Seth




More information about the kernel-team mailing list