[Bionic] [PATCH 2/3] usb: core: Copy parameter string correctly and remove superfluous null check

Kai-Heng Feng kai.heng.feng at canonical.com
Tue Apr 10 09:49:30 UTC 2018

BugLink: https://bugs.launchpad.net/bugs/1762695

strsep() slices string, so the string gets copied by
param_set_copystring() at the end of quirks_param_set() is not the
original value.
Fix that by calling param_set_copystring() earlier.

The null check for val is unnecessary, the caller of quirks_param_set()
does not pass null string.
Remove the superfluous null check. This is found by Smatch.

Fixes: 027bd6cafd9a ("usb: core: Add "quirks" parameter for usbcore")
Cc: Dan Carpenter <dan.carpenter at oracle.com>
Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
(cherry picked from commit a030501499b032bd218e1d01c07677bab6a0d53f)
Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
 drivers/usb/core/quirks.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 11d943a6b7cb..a4f53e1f1ce1 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -31,10 +31,15 @@ static int quirks_param_set(const char *val, const struct kernel_param *kp)
 	u16 vid, pid;
 	u32 flags;
 	size_t i;
+	int err;
+	err = param_set_copystring(val, kp);
+	if (err)
+		return err;
-	if (!val || !*val) {
+	if (!*val) {
 		quirk_count = 0;
 		quirk_list = NULL;
@@ -133,7 +138,7 @@ static int quirks_param_set(const char *val, const struct kernel_param *kp)
-	return param_set_copystring(val, kp);
+	return 0;
 static const struct kernel_param_ops quirks_param_ops = {

More information about the kernel-team mailing list