ACK: [PATCH] ubuntu_kernel_selftests: fix libnuma-dev install for s390x

[Kleber Souza]

For some reason that patch was sent twice to the mailing-list, and
indeed the other thread has been ack'ed and applied :-).


On 05/24/17 10:05, Po-Hsu Lin (Sam) wrote:
> You did ack on this before :)
> 
> For the record, this patch has been applied:
> 
> commit ed0ded85a9fbfffa7d2aebed2d930a87772405f5
> Author: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
> Date:   Fri Apr 21 11:46:10 2017 +0200
> 
>     ubuntu_kernel_selftests: fix libnuma-dev install for s390x
> 
> On Tue, May 23, 2017 at 4:23 PM, Colin Ian King
> <colin.king at canonical.com> wrote:
>> On 21/04/17 10:10, Kleber Sacilotto de Souza wrote:
>>> After commit 27a538cb64541c30cfb0b1e9cc42e1d03d0f5e30
>>> (ubuntu_kernel_selftests: net tests require libnuma-dev), all
>>> ubuntu_kernel_selftests are failing for s390x on series earlier than
>>> Yakkety, since libnuma-dev is being built only from this series on.
>>>
>>> Fix it by not installing the package when running older series on s390x.
>>> Net tests are expected to continue failing though.
>>>
>>> Signed-off-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
>>> ---
>>>  ubuntu_kernel_selftests/ubuntu_kernel_selftests.py | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
>>> index 30e045df..2910fe29 100644
>>> --- a/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
>>> +++ b/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py
>>> @@ -12,8 +12,10 @@ class ubuntu_kernel_selftests(test.test):
>>>          series = platform.dist()[2]
>>>
>>>          pkgs = [
>>> -            'build-essential', 'git', 'libnuma-dev'
>>> +            'build-essential', 'git'
>>>          ]
>>> +        if not (arch == 's390x' and series in ['precise', 'trusty', 'vivid', 'xenial']):
>>> +            pkgs.append('libnuma-dev')
>>>          gcc = 'gcc' if arch in ['ppc64le', 'aarch64', 's390x'] else 'gcc-multilib'
>>>          pkgs.append(gcc)
>>>
>>>
>>
>> This patch doesn't seem to have been reviewed for a while (or I've lost
>> some emails).
>>
>> Anyhow, looks OK to me.
>>
>> Acked-by: Colin Ian King <colin.king at canonical.com>
>>
>> --
>> kernel-team mailing list
>> kernel-team at lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team

-- 
Kleber Souza
Linux Kernel Engineer
Canonical Ltd.