ACK/cmnt: [PATCH] drm/i915: Do not drop pagetables when empty

Stefan Bader stefan.bader at canonical.com
Fri Jul 28 08:11:32 UTC 2017


On 28.07.2017 05:16, Rex Tsai wrote:
> Stefan Bader <stefan.bader at canonical.com <mailto:stefan.bader at canonical.com>> 於
> 2017年7月27日 週四 下午11:19寫道:
> 
>     > i.e. unsuitable for stable. Instead we neuter the code that tried to
>     > free the pagetables.
>     >
>     > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99295
>     > Fixes: 2ce5179fe826 ("drm/i915/gtt: Free unused lower-level page tables")
>     > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk
>     <mailto:chris at chris-wilson.co.uk>>
>     > Cc: Michel Thierry <michel.thierry at intel.com
>     <mailto:michel.thierry at intel.com>>
>     > Cc: Mika Kuoppala <mika.kuoppala at intel.com <mailto:mika.kuoppala at intel.com>>
>     > Cc: Chris Wilson <chris at chris-wilson.co.uk <mailto:chris at chris-wilson.co.uk>>
>     > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com
>     <mailto:joonas.lahtinen at linux.intel.com>>
>     > Cc: Michał Winiarski <michal.winiarski at intel.com
>     <mailto:michal.winiarski at intel.com>>
>     > Cc: Daniel Vetter <daniel.vetter at intel.com <mailto:daniel.vetter at intel.com>>
>     > Cc: Jani Nikula <jani.nikula at linux.intel.com
>     <mailto:jani.nikula at linux.intel.com>>
>     > Cc: intel-gfx at lists.freedesktop.org <mailto:intel-gfx at lists.freedesktop.org>
>     > Cc: <stable at vger.kernel.org <mailto:stable at vger.kernel.org>> # v4.10+
>     > Tested-by: Maël Lavault <mael.lavault at protonmail.com
>     <mailto:mael.lavault at protonmail.com>>
>     > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com
>     <mailto:daniel.vetter at intel.com>>
>     > Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org
>     <mailto:gregkh at linuxfoundation.org>>
>     > (cherry picked from commit 92220696d5d07525443d9280c08c498e77d0386c)
> 
>     Not upstream linux tree, where was the patch picked from? I assume one of the
>     stable trees, but which one?
> 
> 
> As I explained in cover letter[1], it's from stable tree[2].

Ah ok, I missed that. Still this should be hinted in the cherry-pick line of the
patch itself like:

(cherry picked from commit 92220696d5d07525443d9280c08c498e77d0386c linux-4.11.y)

This can be added when applying, so no need to do a v2 for this.

Acked-by: Stefan Bader <stefan.bader at canonical.com>

> 
> % git remote -v
> origingit://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> <http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git> (fetch)
> origingit://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> <http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git> (push)
> % git tag --contains=92220696d5d07525443d9280c08c498e77d0386c
> v4.11.10
> v4.11.11
> v4.11.12
> v4.11.6
> v4.11.7
> v4.11.8
> v4.11.9
> % git branch --contains=92220696d5d07525443d9280c08c498e77d0386c
> * linux-4.11.y
> 
> [1] https://lists.ubuntu.com/archives/kernel-team/2017-July/085964.html
> [2]
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=92220696d5d07525443d9280c08c498e77d0386c
>  


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20170728/d8f6ec57/attachment.sig>


More information about the kernel-team mailing list