[3.16.y-ckt stable] Patch "phy: Find the right match in devm_phy_destroy()" has been added to staging queue

Luis Henriques luis.henriques at canonical.com
Mon Mar 30 13:01:06 UTC 2015

This is a note to let you know that I have just added a patch titled

    phy: Find the right match in devm_phy_destroy()

to the linux-3.16.y-queue branch of the 3.16.y-ckt extended stable tree 
which can be found at:


This patch is scheduled to be released in version 3.16.7-ckt10.

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.16.y-ckt tree, see



>From 0921f9af655d60626a05a4df5247019badf92b06 Mon Sep 17 00:00:00 2001
From: Thierry Reding <treding at nvidia.com>
Date: Wed, 25 Feb 2015 16:16:29 +0100
Subject: phy: Find the right match in devm_phy_destroy()

commit 2f1bce487cd0a02623cff3d877940f9a2026341c upstream.

devm_phy_create() stores the pointer to the new PHY at the address
returned by devres_alloc(). The res parameter passed to devm_phy_match()
is therefore the location where the pointer to the PHY is stored, hence
it needs to be dereferenced before comparing to the match data in order
to find the correct match.

Signed-off-by: Thierry Reding <treding at nvidia.com>
Signed-off-by: Kishon Vijay Abraham I <kishon at ti.com>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
 drivers/phy/phy-core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
index 49c446530101..b7053d02b809 100644
--- a/drivers/phy/phy-core.c
+++ b/drivers/phy/phy-core.c
@@ -50,7 +50,9 @@ static void devm_phy_consume(struct device *dev, void *res)

 static int devm_phy_match(struct device *dev, void *res, void *match_data)
-	return res == match_data;
+	struct phy **phy = res;
+	return *phy == match_data;

 static struct phy *phy_lookup(struct device *device, const char *port)

More information about the kernel-team mailing list