LP#1465998 -- overlayfs "rmdir" panic issue

[Tyler Hicks]

On 2015-06-17 19:17:46, Andy Whitcroft wrote:
> The overlayfs emergency CVE fix backports for trusty, precise and utopic
> have the potential to trigger a kernel panic in the face of cirtain
> operations against directory objects only on the lower layer (at least).
> Following this email are patches for trusty, precise and utopic.
> 
> Proposing for SRU to trusty, precise and utopic.  Vivid and Wily should
> not be affected.
> 
> Reviews appreciated.

Hi Andy - These patches look mostly correct to me but I'm curious why
you chose to wrap some ovl_dentry_root_may() call sites with the NULL
dentry check and left others without such a check?

I would have expected ovl_dentry_root_may() to be changed to return 0 if
realpath->dentry is NULL so that we don't miss adding the check to any
ovl_dentry_root_may() callers.

Tyler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20150617/9fd47af2/attachment.sig>