[Acked/cmt] [PATCH 0/2] [SRU Trusty] Add missing Intel iwlwifi IDs

AceLan Kao acelan.kao at canonical.com
Thu Jan 8 04:57:00 UTC 2015


After applied the 2 commits, the 3160, 7260, and 7250 ID lists are
identical with those in utopic kernel.
And the removed IDs is introduced by the below commit at Jan/23rd and
has been removed since Tue Mar 4 14:47:39 2014 +0200
So, I think those IDs are probably not using in production.

I can provide a backported version of the patch that just contains
adding IDs if you still don't feel confident with the removal.

commit e8325e3aed156fb37ec21aa59bcf7e5550a2bbdf
Author: Oren Givon <oren.givon at intel.com>
Date:   Thu Jan 23 01:19:33 2014 +0200

    iwlwifi: add more 7265 HW IDs

    commit f7690915ccce98553c5425b51e6b5a6c51e27f4e upstream.

    Add 6 new HW IDs for the 7265 series.

2015-01-08 0:08 GMT+08:00 Brad Figg <brad.figg at canonical.com>:
> On Wed, Jan 07, 2015 at 04:28:25PM +0800, AceLan Kao wrote:
>> SRU Justification
>>
>> Impact: Intel 7265 wifi[8086:5412] doesn't work
>>
>> Fix: cherry-pick the below commit which contains the required ID
>>    acfcd9e iwlwifi: fix and add 7265 series HW IDs
>>
>> Testcase: Tested on Intel 7265 [8086:5412] D0 wireless combo card
>>
>> I've checked all the new IDs commits from 3.13 to 3.16 and found that
>> we have all those commits in trusty kernel except the below 2 commits, I would
>> suggest to cherry-pick those 2 commits to avoid more requests for adding IDs.
>>    acfcd9e iwlwifi: fix and add 7265 series HW IDs
>>    8c21c53 iwlwifi: mvm: a few more SKUs for 7260 and 3160
>>
>> Emmanuel Grumbach (1):
>>   iwlwifi: mvm: a few more SKUs for 7260 and 3160
>>
>> Oren Givon (1):
>>   iwlwifi: fix and add 7265 series HW IDs
>>
>>  drivers/net/wireless/iwlwifi/pcie/drv.c | 10 +++++++---
>>  1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> --
>> 2.1.0
>>
>>
>> --
>> kernel-team mailing list
>> kernel-team at lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
>
> I agree with Andy. Can you verify that you really want to remove the IDs in
> the second patch?
>
> If that is correct, ACK.
>
> Brad
> --
> Brad Figg brad.figg at canonical.com http://www.canonical.com




More information about the kernel-team mailing list