[PATCH][TRUSTY] PM / hibernate: Fix restore hang in freeze_processes()
Colin King
colin.king at canonical.com
Tue Mar 4 15:48:28 UTC 2014
From: Sebastian Capella <sebastian.capella at linaro.org>
During restore, pm_notifier chain are called with
PM_RESTORE_PREPARE. The firmware_class driver handler
fw_pm_notify does not have a handler for this. As a result,
it keeps a reader on the kmod.c umhelper_sem. During
freeze_processes, the call to __usermodehelper_disable tries to
take a write lock on this semaphore and hangs waiting.
Signed-off-by: Sebastian Capella <sebastian.capella at linaro.org>
Acked-by: Ming Lei <ming.lei at canonical.com>
Cc: All applicable <stable at vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki at intel.com>
(cherry picked from commit f8d5b9e9e5372f0deb7bc1ab1088a9b60b0a793d)
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
drivers/base/firmware_class.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index eb8fb94..e2b51f8 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -1541,6 +1541,7 @@ static int fw_pm_notify(struct notifier_block *notify_block,
switch (mode) {
case PM_HIBERNATION_PREPARE:
case PM_SUSPEND_PREPARE:
+ case PM_RESTORE_PREPARE:
kill_requests_without_uevent();
device_cache_fw_images();
break;
--
1.9.rc1
More information about the kernel-team
mailing list