[RFC, PATCH 0/2] UBUNTU: lucid: allow printchanges to accept varying release commit messages

Tim Gardner tim.gardner at canonical.com
Tue Feb 22 14:24:00 UTC 2011


On 02/22/2011 12:36 AM, Jeremy Kerr wrote:
> The following patches allow us to specify different regexes for finding
> the base commit of the previous kernel version, used by the printchanges
> target. This will help with OEM kernel builds, which may use differently
> formatted release commit messages. We'd define this on a per-branch
> basis, hence the first patch to (optionally) include branch-specific
> config.
>
> This change is based on lucid, but would be valid for maverick and natty
> as well. It's only a RFC at the moment - if this seems like a sensible
> idea, I'll post patches for maverick and natty -- the context has
> changed enough to make git-am unhappy.
>
> Cheers,
>
>
> Jeremy
>
> ---
> Jeremy Kerr (2):
>        UBUNTU: lucid: include branch-specific makefile fragment
>        UBUNTU: lucid: parameterise base version search string
>
>

Jeremy - the second patch looks fine. As for the first patch, why not 
just add branch customizations to a branch specific file that already 
exists, e.g., debian/debian.env ? In this case, the addition of a branch 
specific macro for printchanges seems appropriate.

rtg
-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list