[Lucid] [Patch 0/3] SRU: Fix usbdux driver timeout and lockups

Stefan Bader stefan.bader at canonical.com
Fri Apr 16 23:03:34 UTC 2010


Leann Ogasawara wrote:
> Hi All,
> 
> https://bugs.edge.launchpad.net/ubuntu/+source/linux/+bug/483343
> 
> SRU Justification/Impact:
> 
> Per the request of the usbdux maintainer, the following patches resolve
> a usbdux driver timeout and lockup.  All three patches have landed in
> 2.6.33 upstream.  Please note that this set of patches depend on the
> patch to fix bug 563436 (ie re-enable comedi drivers).  I recognize we
> are frozen for the upcoming release so please consider this for the
> first Lucid Stable Release Update.
> 
> TEST CASE: 
> 
> I've built a test kernel with the upstream patches applied.  I've
> received confirmation from the bug reporter (usbdux maintainer) that
> this indeed resolves the timeout and lockup.
> 
> =====
> 
> The following changes since commit c2cd04d7aea14bd09bf34126cf916566374132e7:
>   Leann Ogasawara (1):
>         Revert "UBUNTU: staging/comdi -- disable"
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/ogasawara/ubuntu-lucid.git lp483343
> 
> Bernd Porr (3):
>       Staging: comedi: fix usbdux timeout bug
>       Staging: comedi: usbdux.c: fix locking up of the driver when the comedi ringbuffer runs empty
>       Staging: comedi: removed "depricated" from COMEDI_CB_BLOCK
> 
>  drivers/staging/comedi/comedi.h         |    2 +-
>  drivers/staging/comedi/drivers/usbdux.c |   20 ++++++++++++--------
>  2 files changed, 13 insertions(+), 9 deletions(-)
> 
> 
> 
I am happy with those as well. And from the look of those these look like
acceptable for stable too. So we (or Bernd) should send them to
stable at kernel.org with a note that this is for .32.y. There is only one thing
that needs to be changed, which is that the patches sent need to have

commit <upstream sha1> upstream

inserted as the first line of the comment instead of the statement in the s-o-b
area (this is actually a Linus requirement as I learned today).

Stefan




More information about the kernel-team mailing list