Can not build MSS subsystem

Andy Whitcroft apw at canonical.com
Wed Feb 11 15:08:29 UTC 2009


On Tue, Feb 10, 2009 at 09:50:42AM +0800, Zeyan Lu wrote:
> Hi, all
> 
> Regarding: commit 18dabf473e15850c0dbc8ff13ac1e2806d542c15
> change the file (include/asm-x86/scatterlist_32.h), up doing for struct
> scatterlist->page changing to scatterlist->page_link and
> include/linux/scatterlist.h
> 
> this actually breaks the MSS subsystem (drivers/mmc/mss/mmc_protocol.c)
> which relies on the page struct. (drivers/mmc/mss/mmc_protocol.c:619).
> Can anyone suggest a solution to fix it? As of 2.6.24, the MSS subsystem
> cannot compile.
> 
> here is the make log
> **********************************
> root at rd-desktop:/home/intelmid/targets/for_kernel/fs/home/bydk/build/forMk#
> make
> CHK include/linux/version.h
> CHK include/linux/utsrelease.h
> CALL scripts/checksyscalls.sh
> CHK include/linux/compile.h
> CC drivers/mmc/mss/mmc_protocol.o
> drivers/mmc/mss/mmc_protocol.c: In function ‘mmc_card_init’:
> drivers/mmc/mss/mmc_protocol.c:619: error: ‘struct scatterlist’ has no
> member named ‘page’
> make[3]: *** [drivers/mmc/mss/mmc_protocol.o] Error 1
> make[2]: *** [drivers/mmc/mss] Error 2
> make[1]: *** [drivers/mmc] Error 2
> make: *** [drivers] Error 2

That does not appear to be enabled in our distro builds.  So I guess
its not been tested here.  The referenced commits change looks pretty
simple overall.  I would expect that you would need to change all read
references to sg->page to sg_page(sg) and all write references to sg->page
to sg_set_page(sg, ...)  etc.

I have tried to do that in the attached patch which makes it compile and
looks ok to my eye.  I have no hardware to test it on so perhaps you
could give it a go and report back here.

-apw
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-UBUNTU-SAUCE-fix-MSS-MMC-driver-to-match-the-sg-li.patch
Type: text/x-diff
Size: 3328 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20090211/182155e0/attachment.patch>


More information about the kernel-team mailing list