Patch for upgrading iwlwifi drivers

[Tim Gardner]

Tim Gardner wrote:
> Wang, Yong Y wrote:
>> Hello,
>>
>> This is Yong Wang from Rolla's team. Pls find attached the patch against
>> ubuntu-gutsy-lum.git for upgrading iwlwifi drivers from v0.0.42 to
>> v1.0.0-1. As you might know, iwlwifi v0.0.42 which is currently included
>> in ubuntu-gutsy-lum.git has a critical bug that IBSS mode does not work.
>> We already resolved this issue in iwlwifi v1.0.0-1 and our validation on
>> Gutsy tribe 3 showed pretty good results.
>>
>> Could you pls review it and get it merged into git repo if appropriate?
>> Since this is the first time I submit patch, pls let me know if I have
>> done anything wrong in terms of following Ubuntu development process;-)
>> Thank you very much!
>>
>>  <<0001-UBUNTU-iwlwifi-update-to-v1.0.0-1.patch>> 
>>
>> Regards
>> --
>> Yong
>>
>>
>>
> 
> Yong - Thanks for the iwlwifi update. I have several suggestions:
> 
> 1) When updating debian/changelog you should bump the version number. In
> this case from 2.6.22-9.22 to 2.6.22-9.23.
> 
> 2) Ben had trouble reading the EEPROM on at least one machine. The fix
> was to extend the timeout loop count from 10 to 100. I noticed that you
> have reverted this fix.
> 
> -       for (to = 0; to < 100; to++) {
> +       for (to = 0; to < 10; to++) {
> 
> 3) Since you have an account on zinc.ubuntu.com, it is preferable that
> you request a pull from your git repository for gutsy kernel and lum
> changes, while also publishing the patches to
> kernel-team at lists.ubuntu.com. You can use 'git format-patch --stdout' to
> generate an email.
> 
> rtg

I applied this patch and futzed around with a Gutsy install on a Dell
1420 enough to get it working. It does solve one of the bugs I've been
trying to figure out:

https://bugs.launchpad.net/ubuntu/+source/linux-ubuntu-modules-2.6.22/+bug/119563

rtg
-- 
Tim Gardner tim.gardner at ubuntu.com