[Review Queue]

Adam Israel adam.israel at canonical.com
Wed Mar 2 23:36:26 UTC 2016


Memcached

I reviewed two memcached-related proposals today, the former unblocking the
latter.

Allow memcached connections from non-related units:
https://code.launchpad.net/~freyes/charms/trusty/memcached/lp1525026/+merge/287213

Add support for local-monitor interface.

My only note here is that we'd really like to see tests added to cover new
functionality. It's not (currently) a blocker, but as a good practice we
should all take the time to write tests for our code (in a perfect world, I
know).

https://code.launchpad.net/~brad-marshall/charms/trusty/memcached/add-monitors-relation/+merge/276958

Both have my +1 and have been merged.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20160302/fa834e75/attachment.html>


More information about the Juju mailing list