[Review Queue] postgresql

[Adam Israel]

        postgresql

This was a comprehensive review of a new suite of integration tests.
There were intermittent failures that I traced back to a bug in juju
core and other assorted issues with some of our test toolchain. I
resolved those issues (see below) and was able to run most of the tests
successfully.

There were a few changes that needed to be made to the tests themselves,
one correcting a typo and another to increase a timeout. I ended up with
one test failing, though I suspect it’s a logic issue in the test rather
than an actual failure.

bundletester - https://github.com/juju-solutions/bundletester/pull/14:

  * Fixed bug that could lead to |make lint| and |make test| to be run twice

juju-deployer -
https://code.launchpad.net/~aisrael/juju-deployer/workaround-lp-1421315/+merge/254328
<https://code.launchpad.net/%7Eaisrael/juju-deployer/workaround-lp-1421315/+merge/254328>:

  * Added a workaround for an issue with juju api where a subordinate
    unit may not immediately appear in the watch output (see
    lp:1421315), which would cause a deployment to fail.
  * Added a workaround to add_units() where it would attempt to add
    units to a service that was not available via juju api’s status
    output yet.

juju-wait -
https://code.launchpad.net/~aisrael/juju-wait/fix-lock-timeout/+merge/254331
<https://code.launchpad.net/%7Eaisrael/juju-wait/fix-lock-timeout/+merge/254331>

  * Changed the Executor worker count from 6 to 1, to resolve recurring
    “ERROR cannot read info: lock timeout exceeded” errors.

​
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20150326/cc5453f6/attachment.html>