[Review Queue] apache2, kibana, squid-reverseproxy

[Adam Israel]

    apache2

This merge request[1] adds support for an apache-website interface. The
intent of this new interface is to allow subordinate charms to make
opinionated decisions with regard to configuration.

Lint tests fail in an upstream python module (linecache2), where some
python 3 code leaked into its python 2 version. There were also a pair
of unit test failures that I confirmed exist in trunk.

The only thing blocking my +1 is adding some documentation to the README
about this new interface, who should/how it should be used.


    kibana

This merge[2] upgrades Kibana to the latest 4.0.0 release. The install
hook failed, though, due to a naming schema change in the upstream
tarball. I fixed that, as well as updated some version-specific naming
inside the charm, and pushed[3] that up for reference.


    squid-reverseproxy

This merge[4] proposal adds the use of virtualenv for running unit
tests. I found that the code was incomplete, not actually using the venv
it created, so I created a branch as an example that uses installs
dependencies into virtualenv and uses it to run the tests. With that
reference code, the merge passes all tests.

[1]
https://code.launchpad.net/~abentley/charms/trusty/apache2/apache-website/+merge/249758
<https://code.launchpad.net/%7Eabentley/charms/trusty/apache2/apache-website/+merge/249758>
[2]
https://code.launchpad.net/~jorge/charms/trusty/kibana/update-defaults-to-4/+merge/250379
<https://code.launchpad.net/%7Ejorge/charms/trusty/kibana/update-defaults-to-4/+merge/250379>
[3] https://code.launchpad.net/~aisrael/charms/trusty/kibana/fix_v4
<https://code.launchpad.net/%7Eaisrael/charms/trusty/kibana/fix_v4>
[4]
https://code.launchpad.net/~canonical-losas/charms/trusty/squid-reverseproxy/venv-testing/+merge/250574
<https://code.launchpad.net/%7Ecanonical-losas/charms/trusty/squid-reverseproxy/venv-testing/+merge/250574>
[5]
https://code.launchpad.net/~aisrael/charms/trusty/squid-reverseproxy/rework_venv
<https://code.launchpad.net/%7Eaisrael/charms/trusty/squid-reverseproxy/rework_venv>

​
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20150318/225a3ecd/attachment.html>