[Review Queue] neutron-calico related charms and gpfs

[Kevin Monroe]

Hey folks,

Amir, Cory, and I took a look at a few charms in the queue this week:

+ neutron-calico, bird, calico-acl-manager
https://bugs.launchpad.net/charms/+bug/1421230

Neutron-calico is a new charm that adds support for Project Calico
(virtualized cloud networking) to our openstack neutron offering.  It was
failing automated tests due to lint and dependency issues.  The author
included two related charms in the submission (bird and calico-acl-manager)
that had similar minor issues.  Overall, these are great quality charms
that make use of charmhelpers and include unit tests with good coverage.

Aside from the test issues, we asked the author to split each charm into
separate submissions, and I'm happy to say that within 2 hours of our
review, he had the three submissions split out and commits to address the
issues we noted. I look forward to re-reviewing his new work and seeing it
land in the store.

+ gpfs
https://bugs.launchpad.net/charms/+bug/1431045

We were unfortunately not able to get very far with this charm.  GPFS is
licensed by IBM and they currently don't have a public version available.
Without a public repo, installation will fail.  We did make a few comments
based on code inspection (for example, fail faster if the charm knows it
doesn't have a valid repo).  The charm author acknowledged our comments and
is asking IBM if they can find a way to make a public gpfs available.


That's a wrap.  Let me know if you have questions/concerns. Thanks!
-Kevin Monroe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20150313/9f9cdb3e/attachment.html>