Machine agents uninstall themselves upon worker.ErrTerminateAgent.

[William Reade]

On Fri, May 6, 2016 at 11:26 PM, Eric Snow <eric.snow at canonical.com> wrote:

> On Fri, May 6, 2016 at 11:37 AM, William Reade
> <william.reade at canonical.com> wrote:
> > On Fri, May 6, 2016 at 5:50 PM, Eric Snow <eric.snow at canonical.com>
> wrote:
> >>
> >> See https://bugs.launchpad.net/juju-core/+bug/1514874.
> >
> >
> > Mainly, we just shouldn't do it. The only *actual reason* for us to do
> this
> > is to support the manual provider; any other machine that happens to be
> dead
> > will be cleaned up by the responsible provisioner in good time. There's a
> > file we write to enable the suicidal behaviour when we enlist a manual
> > machine, and we *shouldn't* have ever written it for any other reason.
>
> So how about, other than the container bits, we drop the "uninstall"
> code entirely.  To address the manual provider case, during that
> provider's StartInstance() we add a "clean-up-juju" script somewhere
> on the machine?  Then folks can use that to confidently clean up after
> the fact.
>

I'm not keen to regress that without *very* compelling reasons to do so;
and a bit suspicious that installing a clean-up-juju script is itself going
to be a bit of a rabbit hole (once juju's upgraded, the things that need to
be cleaned up might change; at the very least that's an upgrade step to
maintain, but it's also way too easy to just forget that the stored script
could go out of date). Keeping it (as much as possible) in-process strikes
me as more generally reliable; the main thing is dialing way back on the
set of scenarios that can trigger it.

Yeah, if we simply did no automatic cleanup and (on manual provider)
> give users a script that would let them clean up afterward, then they
> could happily(?) manually repair their machines with much less
> trouble.
>

Still -1 myself: as you imply, I'm not sure anyone using this feature will
take on a per-machine manual step particularly "happily" ;).

Cheers
William
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20160507/d2c13660/attachment-0001.html>