A home for underappreciated errors
Andrew Wilkins
andrew.wilkins at canonical.com
Tue Feb 10 08:55:35 UTC 2015
Hi all,
Ian raised a good point in http://reviews.vapour.ws/r/885/ (caution
advised, may cause eyebleed) about a change I made to errors:
https://github.com/juju/errors/pull/17
The NotAssigned error, which previously was only raised by
state.Unit.AssignedMachineId, is now also raised by
state.Volume.StorageInstance. I removed the error from the state package so
we didn't have apiserver/common poking its head in there, and moved it over
to the juju/errors package.
The issue Ian raised is that juju/errors should contain relatively generic
error types, and we should keep domain-specific things elsewhere. Examples
are NotAssigned, and NotProvisioned. We're thinking of moving these
domain-specific error types into a new package, juju/juju/errors. What do
you think about this?
Cheers,
Andrew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20150210/ef24b357/attachment.html>
More information about the Juju-dev
mailing list