previously valid amazon environment now invalid?

roger peppe roger.peppe at canonical.com
Wed Apr 29 08:19:51 UTC 2015


On 29 April 2015 at 01:05, Jesse Meek <jesse.meek at canonical.com> wrote:
> Hi Nate,
>
> I looked into your bug. The default value for control-bucket was not being
> set. Here's a PR to fix: http://reviews.vapour.ws/r/1512/

I'm not entirely sure that's the right fix. The original error message
was right - it was expecting a string value for the config attribute
control-bucket and getting nothing. If we think that message is unclear,
the place to fix the message would be in the schema package.

I don't think that there is a decent fix here - we cannot tell the difference
between environments.yaml entries that are just templates
for bootstrapping and those that are supposed to represent bootstrapped
environments with all the required attributes.

We *could* check that the error is because an attribute is missing,
and hand-wavingly infer that that might be because the environment
has not been bootstrapped, but that may well cover up genuine errors
when specifying an environment fully in environments.yaml.
(and it would be just more cruft in the code base to paper over
an already papered-over issue).

  cheers,
    rog.



More information about the Juju-dev mailing list