ReviewBoard is now the official review tool for juju

[Katherine Cox-Buday]

Let me preface this by saying I like the Reviewboard style of reviewing
changes.

It's somewhat concerning to me that our reviews are now disconnected from
what will actually be landed into trunk. In Github, you were reviewing the
actual diff which would be landed. In reviewboard, we're now reviewing a
diff manually uploaded by the developer. There's a lot of room for error in
terms of what diff we review vs. what diff we land.

Any thoughts on how to couple these things once again?

-
Katherine

On Mon, Sep 15, 2014 at 10:03 AM, Eric Snow <eric.snow at canonical.com> wrote:

> On Sun, Sep 14, 2014 at 10:28 PM, Menno Smits <menno.smits at canonical.com>
> wrote:
> > It looks like the TRACKING_BRANCH option in .reviewboardrc could be
> helpful.
> > It defaults to "origin/master" but if we changed it to "upstream/master"
> I
> > suspect Reviewboard will then generate diffs against the shared master
> > branch instead of what we might happen to have in master in our personal
> > forks. The of course relies on every developer having a remote called
> > "upstream" that points to the right place (which isn't necessarily true).
>
> FWIW, I have the following in $GOPATH/src/github.com/juju/juju/.git/config
> :
>
> [remote "origin"]
>         url = git at github.com:ericsnowcurrently/juju.git
>         fetch = +refs/heads/*:refs/remotes/origin/*
> [remote "upstream"]
>         url = https://github.com/juju/juju.git
>         fetch = +refs/heads/*:refs/remotes/upstream/*
>
> and in ~/.reviewboardrc:
>
> TRACKING_BRANCH = "upstream/master"
>
> This has worked fine for me (once I realized master had to be up-to-date).
>
> -eric
>
> --
> Juju-dev mailing list
> Juju-dev at lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140915/4ba77453/attachment-0001.html>