Please stop adding dependencies to the state package

[David Cheney]

This is https://bugs.launchpad.net/juju-core/+bug/1392520

I have assigned it to myself.

On Fri, Nov 14, 2014 at 10:33 AM, Eric Snow <eric.snow at canonical.com> wrote:
> On Thu, Nov 13, 2014 at 4:05 PM, David Cheney
> <david.cheney at canonical.com> wrote:
>> Hello,
>>
>> Please stop adding dependencies to the state package.
>>
>> The dependency tree for state must go
>>
>> mgo <- state <- things that depend on state
>>
>> At the moment state depends on things like backups, multiwatchers,
>> presence, toolstorage.
>>
>> This is wrong.
>>
>> Eric, i'm not picking on you here, it's just that b sorts first, and
>> this is the one I saw today. There are many other examples, including
>> the multiwatcher which also break this model
>>
>> If you add functionality to state, then the code has to go ***INSIDE**
>> state, or be written to take a *state.State.
>>
>> Please help me out by not adding more dependencies to state.
>
> Thanks for pointing this out, Dave.  I'll fix this for backups.
>
> -eric