Not logging jenv data

Nate Finch nate.finch at canonical.com
Wed May 28 20:25:56 UTC 2014


Today I learned CI isn't running with --debug because they don't want to
expose sensitive data in their jenv... which gets logged when you run with
--debug.  However, it also means that we don't get all our really useful
debug log messages when something breaks in CI.

I made a fix for this (deleting the line that logs the jenv).  Please let
me know if there's any reason we shouldn't do this.  Logging people's
passwords/secrets is generally a big security no-no anyway, so I hope it
won't be controversial.

https://codereview.appspot.com/98580048

-Nate
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140528/4c3076c0/attachment.html>


More information about the Juju-dev mailing list