Code review schedule

[William Reade]

Hey guys

In the interests of broader knowledge sharing, and of quicker review queue
consumption (especially when I'm otherwise engaged), I am reintroducing the
somewhat lapsed concept of an on-call reviewer.

Given the team size, I think we want 2 on-call reviewers at any given time;
I think it is appropriate to approximately divide the reviewers by
experience, so I've roughly chopped us into 2 pools, in which pool 1 is
*generally* composed of people who have several months of current
experience with the codebase, and pool 2 contains everybody else. (I expect
these divisions to become largely meaningless as time passes and everybody
develops a broad understanding of the codebase, but it seemed like a good
way to start.)

On any given day, there will be a reviewer from each pool; each of you is
expected to treat the review queue with higher priority than your
development work on that day, and people who need reviews are encouraged to
come to you to do them. *Nobody* should LGTM something they don't
understand, but you *are* expected to review the current contents of the
queue: you are the first responders, and should each be able to find
*something* to say about everything in the queue. (A series of smart, or
not-so-smart, questions, is perfectly acceptable, whatever pool you're in.)

Once you've started a review, please make an effort to follow up on later
days as it's updated; but please do review everything you can on your own
days, even if someone else has already commented.

Please refer to the linked spreadsheet [0] for the schedule for the
(rolling) next 8 days from yesterday. Be aware that I'm open to changing
how we do this; but let's try it like this for a while and see how we go.

Cheers
William

[0]
https://docs.google.com/a/canonical.com/spreadsheets/d/1iQLLOWrjzxddm5VhYWYi0-2k3xI6wTMlpkvnVNJCYGY/edit#gid=0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140528/1479f607/attachment.html>