(not) using loggo in github.com/juju/errgo
Nate Finch
nate.finch at canonical.com
Tue May 20 11:27:01 UTC 2014
Actually, I just looked at the code again, and the code that uses loggo
will be compiled out unless you modify the code to change a constant.
Let's just remove the code and the package include, and if people want to
modify the code to print out debugging info, they can do that however they
want.
On Tue, May 20, 2014 at 7:24 AM, Nate Finch <nate.finch at canonical.com>wrote:
> I just noticed that errgo uses loggo for one single debug statement. I
> think this is a mistake if we want errgo to be reusable by the community.
> We should strive to make our independent packages actually independent....
> removing unnecessary dependencies is a big part of that. We shouldn't
> force people to include loggo in their product if all they want is
> errgo.... especially given that we're barely using loggo in the package.
>
> Can we remove the debug code, or use the stdlib's logging or something? I
> don't think we're getting a lot of value out of using loggo in this package.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140520/566f24dc/attachment.html>
More information about the Juju-dev
mailing list