Upcoming import change for loggo

Nate Finch nate.finch at canonical.com
Wed Mar 5 20:12:55 UTC 2014


For the record, I'm not a fan of duplicating the package name of anything
in the standard library.   Obviously, sometimes collisions will happen if a
new package is added to the standard library, but it seems like a bad idea
to do it on purpose.  When you're deep in the middle of a file, and you see

log.Printf()

It's nice not to have to go look at the imports to make sure someone's not
accidentally using the std log package when they should be using juju's log
package.

I made the same case for not calling our errors package "errors".   I do
like versioning of packages, though, especially ones likely to be reused
outside of juju.... though I still think running our own vanity url might
be a good idea, rather than a generic one.



On Wed, Mar 5, 2014 at 3:07 PM, Gustavo Niemeyer <gustavo at niemeyer.net>wrote:

> If you used juju/go-log-v1, you might import this as
> gonuts.org/juju/v1/log, which is rather neat, and would properly
> version the API.
>
> On Wed, Mar 5, 2014 at 5:03 PM, Tim Penhey <tim.penhey at canonical.com>
> wrote:
> > Hi all,
> >
> > I'm just preparing a branch that will change the loggo imports from
> >         github.com/loggo/loggo
> > to
> >         github.com/juju/loggo
> >
> > I felt that it would be good to get a bunch of useful Go libraries under
> > the juju banner, and I saw no reason not to put loggo there.
> >
> > If you are using loggo in another Go project, please move it to the new
> > source.
> >
> > Cheers,
> > Tim
> >
> > --
> > Juju-dev mailing list
> > Juju-dev at lists.ubuntu.com
> > Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>
>
>
> --
>
> gustavo @ http://niemeyer.net
>
> --
> Juju-dev mailing list
> Juju-dev at lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140305/fff66dc3/attachment.html>


More information about the Juju-dev mailing list