End Of Review marker

[Horacio Duran]

The idea of the original proposal was, as John says, to act as a chess
watch. All the reviews I got so far make much more sense if I read them and
answer them as a whole instead of disconnected inline comments. The idea of
the EOR comment is to mark the review pass as complete and give place to
the reviewed person to answer/act accordingly. I hope this clarifies what I
meant originally. Cheers

On Thursday, June 12, 2014, Ian Booth <ian.booth at canonical.com> wrote:

>
> > Reitveld didnt send any comments until you sent them all. Github makes
> it a
> > bit harder to know when you've reached a stopping point. (It also makes
> it
> > a bit hard to start with a "this doesn't look right", and come back and
> > remove it when you realize how things are structured.)
> >
>
> Yep, that happened to me today. I made a review comment, and later
> realised it
> was a mistake. But by the time I got back to edit/delete it, the author of
> the
> code had already responded to my incorrect comment.
>
>
> --
> Juju-dev mailing list
> Juju-dev at lists.ubuntu.com <javascript:;>
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140612/f53d8d41/attachment-0001.html>