The idea of the original proposal was, as John says, to act as a chess watch. All the reviews I got so far make much more sense if I read them and answer them as a whole instead of disconnected inline comments. The idea of the EOR comment is to mark the review pass as complete and give place to the reviewed person to answer/act accordingly. I hope this clarifies what I meant originally. Cheers On Thursday, June 12, 2014, Ian Booth <<a href="mailto:ian.booth@canonical.com">ian.booth@canonical.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> > Reitveld didnt send any comments until you sent them all. Github makes it a > bit harder to know when you've reached a stopping point. (It also makes it > a bit hard to start with a "this doesn't look right", and come back and > remove it when you realize how things are structured.) > Yep, that happened to me today. I made a review comment, and later realised it was a mistake. But by the time I got back to edit/delete it, the author of the code had already responded to my incorrect comment. -- Juju-dev mailing list <a href="javascript:;" onclick="_e(event, 'cvml', 'Juju-dev@lists.ubuntu.com')">Juju-dev@lists.ubuntu.com</a> Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/juju-dev" target="_blank">https://lists.ubuntu.com/mailman/listinfo/juju-dev</a> </blockquote>